Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1505023004: ServiceWorker: Early reject error if url is something wrong.

Created:
5 years ago by zino
Modified:
4 years, 11 months ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, falken, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Early reject error if url is something wrong. The openWindow() and navigate() don't allow the special urls[1]. The checking logics for the urls are in chromium side currently but it's better to move them to blink. In case of the special url, we can reject early in blink side using protocolIsInHTTPFamily() method. Also, current implementation resolves null if the request url is about:xxx but we should reject TypeError as per the spec[2]. [1] e.g. about:blank, about:xxx, file:/// and so on. [2] http://slightlyoff.github.io/ServiceWorker/spec/service_worker BUG=none TEST=existing tests

Patch Set 1 #

Total comments: 2

Messages

Total messages: 7 (4 generated)
zino
PTAL
5 years ago (2015-12-09 05:24:15 UTC) #5
nhiroki
There is an open issue about openWindow() w/ "about:" urls[1]. Could you confirm expected behavior ...
5 years ago (2015-12-09 08:35:42 UTC) #6
falken
4 years, 11 months ago (2016-01-26 01:51:11 UTC) #7
Any update on this patch?

Powered by Google App Engine
This is Rietveld 408576698