Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1504743002: Do not show a tooltip same as the previous one. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Do not show a tooltip same as the previous one. If a tooltip is closed by a keyboard event and the mouse cursor was not moved, the same tooltip was shown again after some delay only on Windows. Blink receives native mousemove events repeatedly on Windows even if the mouse cursor is not moved. ChromeClient saves the last tooltip string and the last mouse position, and do not call virtual setToolTip() if they are not changed. This CL not only fixes the bug, but also reduces unnecessary IPC messages for tooltip. BUG=557660 TEST=automated Review URL: https://codereview.chromium.org/1500813004 Cr-Commit-Position: refs/heads/master@{#363174} (cherry picked from commit 91db68e8cb2080d1e9e07858efea3f7e198112a9) Committed: https://chromium.googlesource.com/chromium/src/+/7d44e9fd49f70a1151ae6afb4a098c09f80fe265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/page/ChromeClientTest.cpp View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
5 years ago (2015-12-07 06:11:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d44e9fd49f70a1151ae6afb4a098c09f80fe265 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698