Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1500813004: Do not show a tooltip same as the previous one. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show a tooltip same as the previous one. If a tooltip is closed by a keyboard event and the mouse cursor was not moved, the same tooltip was shown again after some delay only on Windows. Blink receives native mousemove events repeatedly on Windows even if the mouse cursor is not moved. ChromeClient saves the last tooltip string and the last mouse position, and do not call virtual setToolTip() if they are not changed. This CL not only fixes the bug, but also reduces unnecessary IPC messages for tooltip. BUG=557660 TEST=automated Committed: https://crrev.com/91db68e8cb2080d1e9e07858efea3f7e198112a9 Cr-Commit-Position: refs/heads/master@{#363174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/page/ChromeClientTest.cpp View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
yosin@, would you review this please?
5 years ago (2015-12-04 08:16:41 UTC) #2
yosin_UTC9
lgtm It is good change, I love it.
5 years ago (2015-12-04 08:44:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500813004/1
5 years ago (2015-12-04 08:45:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 09:26:01 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-04 09:26:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91db68e8cb2080d1e9e07858efea3f7e198112a9
Cr-Commit-Position: refs/heads/master@{#363174}

Powered by Google App Engine
This is Rietveld 408576698