Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 1504713012: Re-land FastAccessorBuilder. (Closed)

Created:
5 years ago by vogelheim
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-land FastAccessorBuilder. ... using the RawMachineAssembler and the work in crrev.com/1407313004. The original change collided with crrev.com/1513543003. BUG=chromium:508898 LOG=Y Committed: https://crrev.com/515d9ccd8e6df7bf2ca01e2a55aaad30226399e1 Cr-Commit-Position: refs/heads/master@{#32742} patch from issue 1474543004 at patchset 260001 (http://crrev.com/1474543004#ps260001) Committed: https://crrev.com/ee5c38d7db907ff86dd4049721c0cb4bc90a6c4d Cr-Commit-Position: refs/heads/master@{#32753}

Patch Set 1 : Original patch, as reviewed in crrev.com/1474543004 #

Patch Set 2 : Accommodate changes in crrev.com/1513543003. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+855 lines, -17 lines) Patch
M BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M include/v8.h View 3 chunks +9 lines, -4 lines 0 comments Download
A include/v8-experimental.h View 1 chunk +53 lines, -0 lines 0 comments Download
M src/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M src/api.cc View 6 chunks +16 lines, -13 lines 0 comments Download
A src/api-experimental.h View 1 chunk +28 lines, -0 lines 0 comments Download
A src/api-experimental.cc View 1 chunk +126 lines, -0 lines 0 comments Download
A src/compiler/fast-accessor-assembler.h View 1 chunk +106 lines, -0 lines 0 comments Download
A src/compiler/fast-accessor-assembler.cc View 1 1 chunk +223 lines, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-api-fast-accessor-builder.cc View 1 chunk +274 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
vogelheim
5 years ago (2015-12-10 10:43:16 UTC) #2
Michael Starzinger
LGTM on patch set #2, rubber-stamped the rest.
5 years ago (2015-12-10 14:00:38 UTC) #4
epertoso
lgtm
5 years ago (2015-12-10 14:04:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504713012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504713012/20001
5 years ago (2015-12-10 14:11:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 14:14:35 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ee5c38d7db907ff86dd4049721c0cb4bc90a6c4d Cr-Commit-Position: refs/heads/master@{#32753}
5 years ago (2015-12-10 14:15:30 UTC) #11
vogelheim
5 years ago (2015-12-10 14:44:45 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1517683002/ by vogelheim@chromium.org.

The reason for reverting is: Meeh. Now "V8 Linux - gcmole" bot has issues;
apparently due to a somewhat exotic builder configuration..

Powered by Google App Engine
This is Rietveld 408576698