Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1504703002: X87: Remove new.target value from construct stub frames. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove new.target value from construct stub frames. port eaa0e59611f437568a81d76b4d7d446b0d4786a6 (r32550) original commit message: This drops the specific slot containing the new.target value from our construct stub frames. This side-channel has been deprecated and will no longer be accessed by any consumers. BUG= Committed: https://crrev.com/3d40bd941efaf5a8e6b6ce813b255b99369a1d67 Cr-Commit-Position: refs/heads/master@{#32636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 03:27:59 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 03:29:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504703002/1
5 years ago (2015-12-07 03:29:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 03:45:57 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 03:46:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d40bd941efaf5a8e6b6ce813b255b99369a1d67
Cr-Commit-Position: refs/heads/master@{#32636}

Powered by Google App Engine
This is Rietveld 408576698