Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: src/x87/builtins-x87.cc

Issue 1504703002: X87: Remove new.target value from construct stub frames. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x87/builtins-x87.cc
diff --git a/src/x87/builtins-x87.cc b/src/x87/builtins-x87.cc
index d76ba572c38b90de3a56b7a4a2a6a0d46b1fa9b2..130b61660c82ff91b9cb2b379d5e99aa54b9466c 100644
--- a/src/x87/builtins-x87.cc
+++ b/src/x87/builtins-x87.cc
@@ -280,10 +280,6 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ SmiUntag(eax);
- // Push new.target onto the construct frame. This is stored just below the
- // receiver on the stack.
- __ push(edx);
-
if (create_implicit_receiver) {
// Push the allocated receiver to the stack. We need two copies
// because we may have to return the original one and the calling
@@ -347,12 +343,11 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ mov(eax, Operand(esp, 0));
// Restore the arguments count and leave the construct frame. The
- // arguments
- // count is stored below the reciever and the new.target.
+ // arguments count is stored below the receiver.
__ bind(&exit);
- __ mov(ebx, Operand(esp, 2 * kPointerSize));
+ __ mov(ebx, Operand(esp, 1 * kPointerSize));
} else {
- __ mov(ebx, Operand(esp, kPointerSize));
+ __ mov(ebx, Operand(esp, 0));
}
// Leave construct frame.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698