third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp - Issue 1504403003: Calling isSecureContext() with no arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 1504403003: Calling isSecureContext() with no arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored isSecureContext() Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/FileInputType.cpp ('K') | « third_party/WebKit/Source/core/html/forms/FileInputType.cpp ('k') | third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

index e5a42303ece3cc90bba7cb6642b33fd4746e7c7e..0935f858e01706cbee542159bdfb1206a039b4bc 100644

--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

@@ -416,8 +416,7 @@ void InspectorCacheStorageAgent::requestCacheNames(ErrorString* errorString, con

RefPtr<SecurityOrigin> secOrigin = SecurityOrigin::createFromString(securityOrigin);

// Cache Storage API is restricted to trustworthy origins.

- String ignoredMessage;

- if (!secOrigin->isPotentiallyTrustworthy(ignoredMessage)) {

+ if (!secOrigin->isPotentiallyTrustworthy()) {

// Don't treat this as an error, just don't attempt to open and enumerate the caches.

callback->sendSuccess(Array<TypeBuilder::CacheStorage::Cache>::create());

return;