third_party/WebKit/Source/core/html/forms/FileInputType.cpp - Issue 1504403003: Calling isSecureContext() with no arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/FileInputType.cpp

Issue 1504403003: Calling isSecureContext() with no arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored isSecureContext() Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/FileInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/FileInputType.cpp b/third_party/WebKit/Source/core/html/forms/FileInputType.cpp

index c672cb28691b155f4af8fa0b2cf5692e9e0ff0e4..3a9ee9109999bc32d3cbc098d1fded5e9dacdcb4 100644

--- a/third_party/WebKit/Source/core/html/forms/FileInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/FileInputType.cpp

@@ -242,12 +242,8 @@ FileList* FileInputType::createFileList(const Vector<FileChooserFileInfo>& files

void FileInputType::countUsage()

{

- // It is required by isSecureContext() but isn't

- // actually used. This could be used later if a warning is shown in the

- // developer console.

- String insecureOriginMsg;

Document* document = &element().document();

- if (document->isSecureContext(insecureOriginMsg))

+ if (document->ExecutionContext::isSecureContext())

estark 2015/12/18 00:00:58 same

UseCounter::count(*document, UseCounter::InputTypeFileInsecureOrigin);

else

UseCounter::count(*document, UseCounter::InputTypeFileSecureOrigin);