Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1504333003: Address precision issue in circle blur effect (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Address precision issue in circle blur effect BUG=560651 Committed: https://skia.googlesource.com/skia/+/4e56772432825e174b8f9a3370235381482a8f51

Patch Set 1 #

Patch Set 2 : Improve match with skp capture #

Patch Set 3 : Fix the bug #

Patch Set 4 : Clean up #

Patch Set 5 : Fix typo #

Patch Set 6 : Fix overlength line #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -6 lines) Patch
A gm/blurredclippedcircle.cpp View 1 2 3 4 1 chunk +92 lines, -0 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 2 3 4 5 4 chunks +11 lines, -6 lines 2 comments Download

Messages

Total messages: 14 (6 generated)
robertphillips
5 years ago (2015-12-10 17:04:55 UTC) #3
bsalomon
https://codereview.chromium.org/1504333003/diff/100001/src/effects/GrCircleBlurFragmentProcessor.cpp File src/effects/GrCircleBlurFragmentProcessor.cpp (right): https://codereview.chromium.org/1504333003/diff/100001/src/effects/GrCircleBlurFragmentProcessor.cpp#newcode60 src/effects/GrCircleBlurFragmentProcessor.cpp:60: // for precision Should we guard this by if ...
5 years ago (2015-12-10 20:46:05 UTC) #4
bsalomon
lgtm
5 years ago (2015-12-10 20:51:00 UTC) #5
robertphillips
https://codereview.chromium.org/1504333003/diff/100001/src/effects/GrCircleBlurFragmentProcessor.cpp File src/effects/GrCircleBlurFragmentProcessor.cpp (right): https://codereview.chromium.org/1504333003/diff/100001/src/effects/GrCircleBlurFragmentProcessor.cpp#newcode60 src/effects/GrCircleBlurFragmentProcessor.cpp:60: // for precision On 2015/12/10 20:46:05, bsalomon wrote: > ...
5 years ago (2015-12-10 20:51:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504333003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504333003/100001
5 years ago (2015-12-10 20:59:59 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 21:17:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504333003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504333003/100001
5 years ago (2015-12-10 21:28:40 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 21:29:17 UTC) #14
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/4e56772432825e174b8f9a3370235381482a8f51

Powered by Google App Engine
This is Rietveld 408576698