Issue 1504263002: Merge to XFA: Fix rendering with built-in CID fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1504263002: Merge to XFA: Fix rendering with built-in CID fonts (Closed)

Created:
5 years ago by jun_fang

Modified:
5 years ago

Reviewers:
Lei Zhang, Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix rendering with built-in CID fonts The root cause is that FXFONT_SUBST_EXACT is wrongly set even no any subset font was found. It causes m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load(). BUG=534945 R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1502083002 . Committed: https://pdfium.googlesource.com/pdfium/+/4a28a7376367165404eeabdfb4274d30c2d6c040

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	core/src/fxge/ge/fx_ge_fontmap.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

jun_fang

Committed patchset #1 (id:1) manually as 4a28a7376367165404eeabdfb4274d30c2d6c040 (presubmit successful).

5 years ago (2015-12-08 00:33:28 UTC) #3

Message was sent while issue was closed.

lgtm