Fix rendering with built-in CID fonts

Fix rendering with built-in CID fonts

The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().

BUG=534945
R=thestig@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/206310aa43ea87c4e8622f26ae708065bb2f2f77

[jun_fang, 2015-12-06 11:37:42]

Description was changed from

==========
Fix rendering with built-in CID fonts

BUG=534945
==========

to

==========
Fix rendering with built-in CID fonts

The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font is found. It causes 
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().

BUG=534945
==========

[jun_fang, 2015-12-06 11:37:42]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org

[jun_fang, 2015-12-06 11:37:57]

https://codereview.chromium.org/1502083002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (left):

https://codereview.chromium.org/1502083002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:1055: pSubstFont->m_SubstFlags |=
FXFONT_SUBST_EXACT;
FXFONT_SUBST_EXACT should be set at line 1083 after iExact is checked.

[jun_fang, 2015-12-06 11:39:47]

Description was changed from

==========
Fix rendering with built-in CID fonts

The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font is found. It causes 
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().

BUG=534945
==========

to

==========
Fix rendering with built-in CID fonts

The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes 
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().

BUG=534945
==========

[jun_fang, 2015-12-06 11:41:05]

On 2015/12/06 11:37:57, jun_fang wrote:
>
https://codereview.chromium.org/1502083002/diff/1/core/src/fxge/ge/fx_ge_font...
> File core/src/fxge/ge/fx_ge_fontmap.cpp (left):
> 
>
https://codereview.chromium.org/1502083002/diff/1/core/src/fxge/ge/fx_ge_font...
> core/src/fxge/ge/fx_ge_fontmap.cpp:1055: pSubstFont->m_SubstFlags |=
> FXFONT_SUBST_EXACT;
> FXFONT_SUBST_EXACT should be set at line 1083 after iExact is checked.

I tested this patch on both Linux and Windows. It can fix the reported issue.
Lei, can you help me to test it on Mac? thanks!

[jun_fang, 2015-12-07 23:44:15]

jun_fang@foxitsoftware.com changed reviewers:
+ tsepez@chromium.org

[jun_fang, 2015-12-07 23:44:15]

+Tom

[Tom Sepez, 2015-12-07 23:54:27]

lgtm

https://codereview.chromium.org/1502083002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (left):

https://codereview.chromium.org/1502083002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:1055: pSubstFont->m_SubstFlags |=
FXFONT_SUBST_EXACT;
On 2015/12/06 11:37:57, jun_fang wrote:
> FXFONT_SUBST_EXACT should be set at line 1083 after iExact is checked.

Acknowledged.

[Lei Zhang, 2015-12-08 00:04:41]

lgtm, thanks for the fix.

[jun_fang, 2015-12-08 00:19:27]

Description was changed from

==========
Fix rendering with built-in CID fonts

The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes 
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().

BUG=534945
==========

to

==========
Fix rendering with built-in CID fonts

The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().

BUG=534945
R=thestig@chromium.org, tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/206310aa43ea87c4e8622f26ae708065bb2f...
==========

[jun_fang, 2015-12-08 00:19:31]

Committed patchset #1 (id:1) manually as
206310aa43ea87c4e8622f26ae708065bb2f2f77 (presubmit successful).