Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1504183003: Fix favicon updating in document mode. (Closed)

Created:
5 years ago by Ted C
Modified:
5 years ago
Reviewers:
Yusuf, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix favicon updating in document mode. This change modified how we get notified of favicon updates. https://codereview.chromium.org/1464743005/ In particular for native pages, we send a null favicon out and the call sites do not support that. BUG=561996 Committed: https://crrev.com/ac441bfd7987f6ade76a7eea77d67be47de6b33c Cr-Commit-Position: refs/heads/master@{#363672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
5 years ago (2015-12-08 00:01:07 UTC) #2
Yusuf
lgtm
5 years ago (2015-12-08 00:14:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1504183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1504183003/1
5 years ago (2015-12-08 00:16:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 01:16:52 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-08 01:18:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac441bfd7987f6ade76a7eea77d67be47de6b33c
Cr-Commit-Position: refs/heads/master@{#363672}

Powered by Google App Engine
This is Rietveld 408576698