Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4437)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 1504183003: Fix favicon updating in document mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
index 7ebc2da4365a870f782680d2f558c135d54f6fd6..a2fdd312582db9a49bde32a97a06a02642159d26 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -320,6 +320,7 @@ public class WebappActivity extends FullScreenActivity {
if (!isWebappDomain()) return;
// No need to cache the favicon if there is an icon declared in app manifest.
if (mWebappInfo.icon() != null) return;
+ if (icon == null) return;
if (mLargestFavicon == null || icon.getWidth() > mLargestFavicon.getWidth()
|| icon.getHeight() > mLargestFavicon.getHeight()) {
mLargestFavicon = icon;
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698