MediaRecorder tests for Pause functionality

content/browser/media/webrtc_media_recorder_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/test/webrtc_content_browsertest_base.h"
 #include "media/base/media_switches.h"
 
 #if defined(OS_ANDROID)

[mcasas, 2015/12/11 00:08:56]

Can we enable this now?

[cpaulin (no longer in chrome), 2015/12/11 19:56:55]

I wanted to do it in a separate CL so that if it fails it does not impact this
CL, but sure I can enable it

 // TODO(cpaulin): when crbug.com/561068 is fixed, enable this test
 // on android platform.
 #define MAYBE_WebRtcMediaRecorderTest DISABLED_WebRtcMediaRecorderTest
 #else
 #define MAYBE_WebRtcMediaRecorderTest WebRtcMediaRecorderTest
 #endif
 
 namespace {
 
 // Blink features necessary to run the test.
@@ skipping 34 matching lines @@
 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
                        MediaRecorderStartAndStop) {
   MakeTypicalCall("testStartStopAndRecorderState();", kMediaRecorderHtmlFile);
 }
 
 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
                        MediaRecorderStartAndDataAvailable) {
   MakeTypicalCall("testStartAndDataAvailable();", kMediaRecorderHtmlFile);
 }
 
-// Fails flakily under ThreadSanitizer, http://crbug.com/562406.
-#if defined(THREAD_SANITIZER)
-#define MAYBE_MediaRecorderStartWithTimeSlice DISABLED_MediaRecorderStartWithTimeSlice
-#else
-#define MAYBE_MediaRecorderStartWithTimeSlice MediaRecorderStartWithTimeSlice
-#endif

[mcasas, 2015/12/11 00:08:56]

Hmm all this seems to be dragging from 
https://codereview.chromium.org/1502693002,
I guess you should rebase and re-upload so
these changes won't show up. You can do it
at the same time you address the comments.

[cpaulin (no longer in chrome), 2015/12/11 19:56:55]

Yes, I took it out

 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
-                       MAYBE_MediaRecorderStartWithTimeSlice) {
+                       MediaRecorderStartWithTimeSlice) {
   MakeTypicalCall("testStartWithTimeSlice();", kMediaRecorderHtmlFile);
 }
 
 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest, MediaRecorderStartEvent) {
   MakeTypicalCall("testStartAndStartEventTriggered();", kMediaRecorderHtmlFile);
 }
 
 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
                        MediaRecorderStopEvent) {
   MakeTypicalCall("testStartStopAndStopEventTriggered();",
@@ skipping 14 matching lines @@
                        MediaRecorderNoResumeWhenRecorderInactive) {
   MakeTypicalCall("testNoResumeWhileRecorderInactive();",
       kMediaRecorderHtmlFile);
 }
 
 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
                        MediaRecorderResumeAndDataAvailable) {
   MakeTypicalCall("testResumeAndDataAvailable();", kMediaRecorderHtmlFile);
 }
 
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+                       MediaRecorderPause) {
+  MakeTypicalCall("testPauseAndRecorderState();", kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+                       MediaRecorderPauseStop) {
+  MakeTypicalCall("testPauseStopAndRecorderState();", kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+                       MediaRecorderPauseEvent) {
+  MakeTypicalCall("testPauseAndPauseEventTriggered();", kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+                       MediaRecorderPauseAndNoDataAvailable) {
+  MakeTypicalCall("testPauseAndNoDataAvailable();", kMediaRecorderHtmlFile);
+}
+
+IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
+                       MediaRecorderNoPauseWhenRecorderInactive) {
+  MakeTypicalCall("testNoPauseWhileRecorderInactive();",
+      kMediaRecorderHtmlFile);
+}
+
 }  // namespace content