Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1502693002: Undo WebRtcMediaRecorderTest.MediaRecorderStartWithTimeSlice exclusion (Closed)

Created:
5 years ago by cpaulin (no longer in chrome)
Modified:
5 years ago
CC:
chromium-reviews, phoglund+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, tnakamura+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Undo WebRtcMediaRecorderTest.MediaRecorderStartWithTimeSlice exclusion BUG=chromium:562406 Committed: https://crrev.com/00c9d6de393869df9d3ac1b1f0d244cc53498fa0 Cr-Commit-Position: refs/heads/master@{#363405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M content/browser/media/webrtc_media_recorder_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
cpaulin (no longer in chrome)
Reversal of crbug/1479973002 and crbug/1488613005 tommi@, since phoglund@ might be away could you take a ...
5 years ago (2015-12-04 22:34:33 UTC) #4
Lei Zhang
lgtm, but you need someone else to approve content/
5 years ago (2015-12-04 22:48:27 UTC) #5
chromium-reviews
Yes indeed, I asked tommi@ On Fri, Dec 4, 2015 at 2:48 PM, <thestig@chromium.org> wrote: ...
5 years ago (2015-12-04 22:52:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502693002/1
5 years ago (2015-12-04 23:02:09 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-12-05 01:07:51 UTC) #10
tommi (sloooow) - chröme
lgtm
5 years ago (2015-12-05 17:03:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502693002/1
5 years ago (2015-12-05 17:04:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 19:07:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502693002/1
5 years ago (2015-12-07 07:26:45 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 07:55:26 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-07 07:56:58 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00c9d6de393869df9d3ac1b1f0d244cc53498fa0
Cr-Commit-Position: refs/heads/master@{#363405}

Powered by Google App Engine
This is Rietveld 408576698