Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

Issue 1504013004: GC plugin: remove mixin trace override restriction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt
diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt
index 15231c106d7c509260fefcbcf3de9cbe23d5cdc2..de6fd949adda1b2c73e5762bac61a2800f7caea0 100644
--- a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt
@@ -11,10 +11,4 @@ class HeapObject : public GarbageCollected<HeapObject> {
./class_requires_trace_method.h:22:5: note: [blink-gc] Untraced field 'm_part' declared here:
PartObject m_part;
^
-./class_requires_trace_method.h:31:1: warning: [blink-gc] Class 'HeapObjectMixin' which inherits from GarbageCollectedMixin must locally declare and override trace(Visitor*)
-class HeapObjectMixin : public GarbageCollected<HeapObjectMixin>, public Mixin {
-^
-./class_requires_trace_method.h:40:1: warning: [blink-gc] Class 'HeapObjectMixin2' which inherits from GarbageCollectedMixin must locally declare and override trace(Visitor*)
-class HeapObjectMixin2
-^
-4 warnings generated.
+2 warnings generated.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698