Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

Issue 1504013004: GC plugin: remove mixin trace override restriction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt
diff --git a/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt b/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt
index a8f270bfb6fba143285163d59a851616b7915db8..33ae5f550ac7cfe98d7e92e1a3ae225f0d020893 100644
--- a/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt
+++ b/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt
@@ -1,14 +1,14 @@
In file included from class_multiple_trace_bases.cpp:5:
-./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' requires a trace method.
-class Derived : public Base, public Mixin {
+./class_multiple_trace_bases.h:27:1: warning: [blink-gc] Class 'Derived1' requires a trace method.
+class Derived1 : public Base, public Mixin1 {
^
-./class_multiple_trace_bases.h:22:17: note: [blink-gc] Untraced base class 'Base' declared here:
-class Derived : public Base, public Mixin {
- ^
-./class_multiple_trace_bases.h:22:30: note: [blink-gc] Untraced base class 'Mixin' declared here:
-class Derived : public Base, public Mixin {
- ^
-./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' which inherits from GarbageCollectedMixin must locally declare and override trace(Visitor*)
-class Derived : public Base, public Mixin {
+./class_multiple_trace_bases.h:27:18: note: [blink-gc] Untraced base class 'Base' declared here:
+class Derived1 : public Base, public Mixin1 {
+ ^
+./class_multiple_trace_bases.h:27:31: note: [blink-gc] Untraced base class 'Mixin1' declared here:
+class Derived1 : public Base, public Mixin1 {
+ ^
+class_multiple_trace_bases.cpp:17:1: warning: [blink-gc] Base class 'Mixin2' of derived class 'Derived2' requires tracing.
+void Derived2::trace(Visitor* visitor) {
^
2 warnings generated.

Powered by Google App Engine
This is Rietveld 408576698