Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

Issue 1504013004: GC plugin: remove mixin trace override restriction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 In file included from class_multiple_trace_bases.cpp:5: 1 In file included from class_multiple_trace_bases.cpp:5:
2 ./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' require s a trace method. 2 ./class_multiple_trace_bases.h:27:1: warning: [blink-gc] Class 'Derived1' requir es a trace method.
3 class Derived : public Base, public Mixin { 3 class Derived1 : public Base, public Mixin1 {
4 ^ 4 ^
5 ./class_multiple_trace_bases.h:22:17: note: [blink-gc] Untraced base class 'Base ' declared here: 5 ./class_multiple_trace_bases.h:27:18: note: [blink-gc] Untraced base class 'Base ' declared here:
6 class Derived : public Base, public Mixin { 6 class Derived1 : public Base, public Mixin1 {
7 ^ 7 ^
8 ./class_multiple_trace_bases.h:22:30: note: [blink-gc] Untraced base class 'Mixi n' declared here: 8 ./class_multiple_trace_bases.h:27:31: note: [blink-gc] Untraced base class 'Mixi n1' declared here:
9 class Derived : public Base, public Mixin { 9 class Derived1 : public Base, public Mixin1 {
10 ^ 10 ^
11 ./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' which i nherits from GarbageCollectedMixin must locally declare and override trace(Visit or*) 11 class_multiple_trace_bases.cpp:17:1: warning: [blink-gc] Base class 'Mixin2' of derived class 'Derived2' requires tracing.
12 class Derived : public Base, public Mixin { 12 void Derived2::trace(Visitor* visitor) {
13 ^ 13 ^
14 2 warnings generated. 14 2 warnings generated.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698