Any mouse click selects a drop down list item, when it shouldn't...

webkit/port/platform/chromium/PopupMenuChromium.cpp

Index: webkit/port/platform/chromium/PopupMenuChromium.cpp
===================================================================
--- webkit/port/platform/chromium/PopupMenuChromium.cpp	(revision 7195)
+++ webkit/port/platform/chromium/PopupMenuChromium.cpp	(working copy)
@@ -511,6 +511,10 @@
         return true;
     }
 
+    // Only process the left button click.
+    if (event.button() != LeftButton)

[Matt Perry, 2008/12/18 22:34:35]

Since this is before the "abandon" step, does right-clicking outside the select
no longer dismiss the select?  I think it should.

[Evan Stade, 2008/12/19 00:19:56]

If it's moved to after the abandon() step, it will have no effect. I don't think
any check is needed in this function.

+        return true;
+
     if (!isPointInBounds(event.pos()))
         abandon();
 
@@ -552,6 +556,10 @@
         return true;
     }
 
+    // Only process the left button click.
+    if (event.button() != LeftButton)
+        return true;
+
     if (!isPointInBounds(event.pos()))
         return true;