Any mouse click selects a drop down list item, when it shouldn't...

webkit/port/platform/chromium/PopupMenuChromium.cpp

 // Copyright (c) 2008, Google Inc.
 // All rights reserved.
 // 
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 // 
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 493 matching lines @@
 
 bool PopupListBox::handleMouseDownEvent(const PlatformMouseEvent& event)
 {
     Scrollbar* scrollbar = scrollbarUnderMouse(event);
     if (scrollbar) {
         m_capturingScrollbar = scrollbar;
         m_capturingScrollbar->mouseDown(event);
         return true;
     }
 
+    // Only process the left button click.
+    if (event.button() != LeftButton)

[Matt Perry, 2008/12/18 22:34:35]

Since this is before the "abandon" step, does right-clicking outside the select
no longer dismiss the select?  I think it should.

[Evan Stade, 2008/12/19 00:19:56]

If it's moved to after the abandon() step, it will have no effect. I don't think
any check is needed in this function.

+        return true;
+
     if (!isPointInBounds(event.pos()))
         abandon();
 
     return true;
 }
 
 bool PopupListBox::handleMouseMoveEvent(const PlatformMouseEvent& event)
 {
     if (m_capturingScrollbar) {
         m_capturingScrollbar->mouseMoved(event);
@@ skipping 21 matching lines @@
 }
 
 bool PopupListBox::handleMouseReleaseEvent(const PlatformMouseEvent& event)
 {
     if (m_capturingScrollbar) {
         m_capturingScrollbar->mouseUp();
         m_capturingScrollbar = 0;
         return true;
     }
 
+    // Only process the left button click.
+    if (event.button() != LeftButton)
+        return true;
+
     if (!isPointInBounds(event.pos()))
         return true;
 
     acceptIndex(pointToRowIndex(event.pos()));
     return true;
 }
 
 bool PopupListBox::handleWheelEvent(const PlatformWheelEvent& event)
 {
     if (!isPointInBounds(event.pos())) {
@@ skipping 545 matching lines @@
 {
     p.m_popup->listBox()->updateFromElement();
 }
 
 bool PopupMenu::itemWritingDirectionIsNatural() 
 { 
     return false; 
 }
 
 } // namespace WebCore