Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 1503943003: [Cronet] Unit test refactoring and fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
index 0df78f9bb3ad0ee1b221425a4d6ba24e56a64059..902797daaf74f516a35c3a1f84f294e5ddbb61ae 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
@@ -66,11 +66,7 @@ public class QuicTest extends CronetTestBase {
String[] commandLineArgs = {
CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LibraryInitType.LEGACY};
mTestFramework = new CronetTestFramework(null, commandLineArgs, getContext(), mBuilder);
-
- long urlRequestContextAdapter = ((ChromiumUrlRequestFactory) mTestFramework.mRequestFactory)
- .getRequestContext()
- .getUrlRequestContextAdapter();
- NativeTestServer.registerHostResolverProc(urlRequestContextAdapter, true);
+ registerHostResolver(mTestFramework, true);
String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
HashMap<String, String> headers = new HashMap<String, String>();
@@ -94,14 +90,8 @@ public class QuicTest extends CronetTestBase {
@LargeTest
@Feature({"Cronet"})
public void testQuicLoadUrl() throws Exception {
- String[] commandLineArgs = {
- CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LibraryInitType.CRONET};
- mTestFramework = new CronetTestFramework(null, commandLineArgs, getContext(), mBuilder);
-
- long urlRequestContextAdapter = ((CronetUrlRequestContext) mTestFramework.mCronetEngine)
- .getUrlRequestContextAdapter();
- NativeTestServer.registerHostResolverProc(urlRequestContextAdapter, false);
-
+ mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, mBuilder);
+ registerHostResolver(mTestFramework);
String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
TestUrlRequestCallback callback = new TestUrlRequestCallback();
@@ -145,13 +135,11 @@ public class QuicTest extends CronetTestBase {
builder.enableHttpCache(CronetEngine.Builder.HTTP_CACHE_DISK, 1000 * 1024);
builder.enableQUIC(true);
builder.setMockCertVerifierForTesting(MockCertVerifier.createMockCertVerifier(CERTS_USED));
- CronetEngine newEngine = new CronetUrlRequestContext(builder);
- long newUrlRequestContextAdapter =
- ((CronetUrlRequestContext) newEngine).getUrlRequestContextAdapter();
- NativeTestServer.registerHostResolverProc(newUrlRequestContextAdapter, false);
+ mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+ registerHostResolver(mTestFramework);
TestUrlRequestCallback callback2 = new TestUrlRequestCallback();
- requestBuilder =
- new UrlRequest.Builder(quicURL, callback2, callback2.getExecutor(), newEngine);
+ requestBuilder = new UrlRequest.Builder(
+ quicURL, callback2, callback2.getExecutor(), mTestFramework.mCronetEngine);
requestBuilder.build().start();
callback2.blockForDone();
assertEquals(200, callback2.mResponseInfo.getHttpStatusCode());

Powered by Google App Engine
This is Rietveld 408576698