Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java

Issue 1503943003: [Cronet] Unit test refactoring and fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
index b810c65660f5534ec51b18555914086fc32a672e..1b6107b5e9f2a30bf8ef2b380648e1fc0d7ed771 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
@@ -66,7 +66,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256(mServerHost, nonMatchingHash, EXCLUDE_SUBDOMAINS, DISTANT_FUTURE);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertErrorResponse();
@@ -87,7 +87,7 @@ public class PkpTest extends CronetTestBase {
addPkpSha256(mServerHost, matchingHash, EXCLUDE_SUBDOMAINS, DISTANT_FUTURE);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertSuccessfulResponse();
@@ -106,7 +106,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256(mDomain, nonMatchingHash, INCLUDE_SUBDOMAINS, DISTANT_FUTURE);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertErrorResponse();
@@ -125,7 +125,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256(mDomain, nonMatchingHash, EXCLUDE_SUBDOMAINS, DISTANT_FUTURE);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertSuccessfulResponse();
@@ -144,7 +144,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256("otherhost.com", nonMatchingHash, INCLUDE_SUBDOMAINS, DISTANT_FUTURE);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertSuccessfulResponse();
@@ -163,7 +163,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256(mServerHost, nonMatchingHash, EXCLUDE_SUBDOMAINS, tenSecondsAhead);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertErrorResponse();
@@ -182,7 +182,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256(mServerHost, nonMatchingHash, EXCLUDE_SUBDOMAINS, oneSecondAgo);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertSuccessfulResponse();
@@ -199,7 +199,7 @@ public class PkpTest extends CronetTestBase {
byte[] nonMatchingHash = generateSomeSha256();
addPkpSha256(mServerHost, nonMatchingHash, EXCLUDE_SUBDOMAINS, DISTANT_FUTURE);
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertErrorResponse();
shutdownCronetEngine();
@@ -208,7 +208,7 @@ public class PkpTest extends CronetTestBase {
// a successful response is expected.
createCronetEngineBuilder();
startCronetFramework();
- registerHostResolver();
+ registerHostResolver(mTestFramework);
sendRequestAndWaitForResult();
assertSuccessfulResponse();
}
@@ -347,12 +347,6 @@ public class PkpTest extends CronetTestBase {
}
}
- private void registerHostResolver() {
- long urlRequestContextAdapter = ((CronetUrlRequestContext) mTestFramework.mCronetEngine)
- .getUrlRequestContextAdapter();
- NativeTestServer.registerHostResolverProc(urlRequestContextAdapter, false);
- }
-
private byte[] generateSomeSha256() {
byte[] sha256 = new byte[32];
Arrays.fill(sha256, (byte) 58);

Powered by Google App Engine
This is Rietveld 408576698