Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: src/trusted/reverse_service/reverse_service.h

Issue 15039022: Enable meta-based validation for shared libraries. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Style Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/reverse_service/nacl_file_info.h ('k') | src/trusted/reverse_service/reverse_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/reverse_service/reverse_service.h
diff --git a/src/trusted/reverse_service/reverse_service.h b/src/trusted/reverse_service/reverse_service.h
index 1b11f15dba65e7e273ee99ddb3afd22c944409f9..4c75050e5c3d3c973694158557002a90f969d88f 100644
--- a/src/trusted/reverse_service/reverse_service.h
+++ b/src/trusted/reverse_service/reverse_service.h
@@ -22,6 +22,8 @@
#include "native_client/src/trusted/service_runtime/include/sys/errno.h"
#include "native_client/src/trusted/service_runtime/include/sys/nacl_name_service.h"
+struct NaClFileInfo;
+
namespace nacl {
// The CreateProcessFunctorInterface allows delivery of results to an
@@ -76,7 +78,13 @@ class ReverseInterface : public RefCountBase {
// Since shutdown/surfaway is the only admissible error, we use bool
// as the return type.
virtual bool EnumerateManifestKeys(std::set<nacl::string>* keys) = 0;
- virtual bool OpenManifestEntry(nacl::string url_key, int32_t* out_desc) = 0;
+
+ // An adapter to prevent this interface change from breaking the DEPS roll.
+ // TODO(ncbray) remove
+ virtual bool OpenManifestEntry(nacl::string url_key, int32_t* out_desc);
+ // TODO(ncbray) convert to a pure virtual.
+ virtual bool OpenManifestEntry(nacl::string url_key,
+ struct NaClFileInfo* info);
virtual bool CloseManifestEntry(int32_t desc) = 0;
virtual void ReportCrash() = 0;
« no previous file with comments | « src/trusted/reverse_service/nacl_file_info.h ('k') | src/trusted/reverse_service/reverse_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698