Enable meta-based validation for shared libraries.

src/trusted/reverse_service/reverse_service.h

 /* -*- c++ -*- */
 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_
 
 #include <set>
 
 #include "native_client/src/include/nacl_compiler_annotations.h"
 #include "native_client/src/include/nacl_macros.h"
 #include "native_client/src/include/nacl_scoped_ptr.h"
 #include "native_client/src/include/nacl_string.h"
 
 #include "native_client/src/shared/platform/refcount_base.h"
 #include "native_client/src/shared/platform/nacl_sync.h"
 #include "native_client/src/trusted/desc/nacl_desc_wrapper.h"
 #include "native_client/src/trusted/reverse_service/reverse_service_c.h"
 #include "native_client/src/trusted/service_runtime/include/sys/errno.h"
 #include "native_client/src/trusted/service_runtime/include/sys/nacl_name_service.h"
 
+struct NaClFileInfo;
+
 namespace nacl {
 
 // The CreateProcessFunctorInterface allows delivery of results to an
 // RPC handler via the Results arguments.  This is so that RPC
 // handlers can invoke their done closure to send the output arguments
 // -- when the functor returns, the code that invoked the
 // CreateProcessFunctorInterface can unlock mutex locks, deallocate
 // memory, or finalize storage as needed.  (See the 2-phase comment in
 // src/trusted/sel_universal/reverse_emulate.cc,
 // ReverseEmulate::CreateProcessFunctorResult.)
@@ skipping 34 matching lines @@
 
   // The bool functions returns false if the service thread unblocked
   // because of surf-away, shutdown, or other issues.  The plugin,
   // when it tells sel_ldr to shut down, will also signal all threads
   // that are waiting for main thread callbacks to wake up and abandon
   // their vigil after the callbacks are all cancelled (by abandoning
   // the WeakRefAnchor or by bombing their CompletionCallbackFactory).
   // Since shutdown/surfaway is the only admissible error, we use bool
   // as the return type.
   virtual bool EnumerateManifestKeys(std::set<nacl::string>* keys) = 0;
-  virtual bool OpenManifestEntry(nacl::string url_key, int32_t* out_desc) = 0;
+
+  // An adapter to prevent this interface change from breaking the DEPS roll.
+  // TODO(ncbray) remove
+  virtual bool OpenManifestEntry(nacl::string url_key, int32_t* out_desc);
+  // TODO(ncbray) convert to a pure virtual.
+  virtual bool OpenManifestEntry(nacl::string url_key,
+                                 struct NaClFileInfo* info);
   virtual bool CloseManifestEntry(int32_t desc) = 0;
   virtual void ReportCrash() = 0;
 
   // The low-order 8 bits of the |exit_status| should be reported to
   // any interested parties.
   virtual void ReportExitStatus(int exit_status) = 0;
 
   // Standard output and standard error redirection, via setting
   // NACL_EXE_STDOUT to the string "DEBUG_ONLY:dev://postmessage" (see
   // native_client/src/trusted/nacl_resource.* and sel_ldr).  NB: the
@@ skipping 86 matching lines @@
  private:
   NACL_DISALLOW_COPY_AND_ASSIGN(ReverseService);
 
   NaClReverseService* service_;
   ReverseInterface* reverse_interface_;
 };
 
 }  // namespace nacl
 
 #endif