Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 15038002: Revert "deprecate Context::New which returns Persistent" (Closed)

Created:
7 years, 7 months ago by Michael Starzinger
Modified:
7 years, 7 months ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Revert "deprecate Context::New which returns Persistent" This reverts r14573 because of test failures in no-snapshot mode in the cctest/test-debug/ScriptCollectedEventContext test case. TBR=dcarney@chromium.org,svenpanne@chromium.org TEST=cctest/test-debug/ScriptCollectedEventContext Committed: http://code.google.com/p/v8/source/detail?r=14578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -328 lines) Patch
M include/v8.h View 1 chunk +5 lines, -5 lines 0 comments Download
M samples/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 7 chunks +32 lines, -34 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +2 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 59 chunks +135 lines, -136 lines 0 comments Download
M test/cctest/test-debug.cc View 11 chunks +21 lines, -23 lines 0 comments Download
M test/cctest/test-decls.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M test/cctest/test-hashing.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +12 lines, -36 lines 0 comments Download
M test/cctest/test-lockers.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M test/cctest/test-random.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 7 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
7 years, 7 months ago (2013-05-07 16:28:28 UTC) #1
Michael Starzinger
7 years, 7 months ago (2013-05-07 16:29:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r14578 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698