chrome/browser/ui/views/browser_dialogs_views_mac.cc - Issue 1503583002: [Extensions Views] Update the extension installed bubble's sync promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_dialogs_views_mac.cc

Issue 1503583002: [Extensions Views] Update the extension installed bubble's sync promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/extension_installed_bubble.cc ('K') | « chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view_unittest.cc ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.h » ('j') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_dialogs_views_mac.cc

diff --git a/chrome/browser/ui/views/browser_dialogs_views_mac.cc b/chrome/browser/ui/views/browser_dialogs_views_mac.cc

index 1a8e754e87319a3f34abddc13c82c51b66398e42..0f4d665646d26a237c6954e6533ddf0e603c67a2 100644

--- a/chrome/browser/ui/views/browser_dialogs_views_mac.cc

+++ b/chrome/browser/ui/views/browser_dialogs_views_mac.cc

@@ -35,7 +35,7 @@ void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,

const GURL& url,

bool already_bookmarked) {

// The Views dialog may prompt for sign in.

- scoped_ptr<BookmarkBubbleDelegate> delegate(

+ scoped_ptr<BubbleSyncPromoDelegate> delegate(

new BookmarkBubbleSignInDelegate(browser));

BookmarkBubbleView::ShowBubble(nullptr, gfx::Rect(anchor_point, gfx::Size()),