Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: chrome/browser/ui/extensions/extension_installed_bubble.cc

Issue 1503583002: [Extensions Views] Update the extension installed bubble's sync promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_installed_bubble.cc
diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.cc b/chrome/browser/ui/extensions/extension_installed_bubble.cc
index 0f8accb2e09fab452697abde4c1c0dbc23b6e4da..04ad489ff83ce5ae0d9d9fc283e814fdc4b52ce2 100644
--- a/chrome/browser/ui/extensions/extension_installed_bubble.cc
+++ b/chrome/browser/ui/extensions/extension_installed_bubble.cc
@@ -56,6 +56,10 @@ class ExtensionInstalledBubbleObserver
content::Source<Browser>(bubble_->browser()));
}
+ void Run() {
+ OnExtensionLoaded(nullptr, bubble_->extension());
+ }
+
private:
~ExtensionInstalledBubbleObserver() override {}
@@ -169,8 +173,13 @@ void ExtensionInstalledBubble::ShowBubble(
const SkBitmap& icon) {
// The ExtensionInstalledBubbleObserver will delete itself when the
// ExtensionInstalledBubble is shown or when it can't be shown anymore.
- new ExtensionInstalledBubbleObserver(
+ auto x = new ExtensionInstalledBubbleObserver(
sky 2015/12/04 23:41:06 x, huh? bubble_observer?
Devlin 2015/12/05 01:10:15 D'oh! This was all for testing. I remembered to
make_scoped_ptr(new ExtensionInstalledBubble(extension, browser, icon)));
+ extensions::ExtensionRegistry* reg =
+ extensions::ExtensionRegistry::Get(browser->profile());
+ if (reg->enabled_extensions().GetByID(extension->id())) {
sky 2015/12/04 23:41:06 nit: no {}
Devlin 2015/12/05 01:10:15 Ditto.
+ x->Run();
+ }
}
ExtensionInstalledBubble::ExtensionInstalledBubble(const Extension* extension,

Powered by Google App Engine
This is Rietveld 408576698