[Extensions Views] Update the extension installed bubble's sync promo

chrome/browser/ui/extensions/extension_installed_bubble.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/extension_installed_bubble.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 38 matching lines @@
         weak_factory_(this) {
     // |extension| has been initialized but not loaded at this point. We need to
     // wait on showing the Bubble until the EXTENSION_LOADED gets fired.
     extension_registry_observer_.Add(
         extensions::ExtensionRegistry::Get(bubble_->browser()->profile()));
 
     registrar_.Add(this, chrome::NOTIFICATION_BROWSER_CLOSING,
                    content::Source<Browser>(bubble_->browser()));
   }
 
+  void Run() {
+    OnExtensionLoaded(nullptr, bubble_->extension());
+  }
+
  private:
   ~ExtensionInstalledBubbleObserver() override {}
 
   // content::NotificationObserver:
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override {
     DCHECK_EQ(type, chrome::NOTIFICATION_BROWSER_CLOSING)
         << "Received unexpected notification";
     // Browser is closing before the bubble was shown.
@@ skipping 93 matching lines @@
 
 }  // namespace
 
 // static
 void ExtensionInstalledBubble::ShowBubble(
     const extensions::Extension* extension,
     Browser* browser,
     const SkBitmap& icon) {
   // The ExtensionInstalledBubbleObserver will delete itself when the
   // ExtensionInstalledBubble is shown or when it can't be shown anymore.
-  new ExtensionInstalledBubbleObserver(
+  auto x = new ExtensionInstalledBubbleObserver(

[sky, 2015/12/04 23:41:06]

x, huh? bubble_observer?

[Devlin, 2015/12/05 01:10:15]

D'oh!  This was all for testing.  I remembered to revert the other files, but
missed this one.

       make_scoped_ptr(new ExtensionInstalledBubble(extension, browser, icon)));
+  extensions::ExtensionRegistry* reg =
+      extensions::ExtensionRegistry::Get(browser->profile());
+  if (reg->enabled_extensions().GetByID(extension->id())) {

[sky, 2015/12/04 23:41:06]

nit: no {}

[Devlin, 2015/12/05 01:10:15]

Ditto.

+    x->Run();
+  }
 }
 
 ExtensionInstalledBubble::ExtensionInstalledBubble(const Extension* extension,
                                                    Browser* browser,
                                                    const SkBitmap& icon)
     : extension_(extension), browser_(browser), icon_(icon) {
   if (!extensions::OmniboxInfo::GetKeyword(extension).empty())
     type_ = OMNIBOX_KEYWORD;
   else if (extensions::ActionInfo::GetBrowserActionInfo(extension))
     type_ = BROWSER_ACTION;
@@ skipping 41 matching lines @@
 
   if (message_id == 0)
     return base::string16();
   return extra.empty() ? l10n_util::GetStringUTF16(message_id) :
       l10n_util::GetStringFUTF16(message_id, extra);
 }
 
 void ExtensionInstalledBubble::OnExtensionLoaded() {
   action_command_ = GetCommand(extension_->id(), browser_->profile(), type_);
 }