Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1503553003: Add another CHECK to diagnose Android crash. (Closed)

Created:
5 years ago by Alexei Svitkine (slow)
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add another CHECK to diagnose Android crash. The suspicion is something is causing an inconsistency field trial state (i.e. group changing). Catch this earlier in the browser process with a CHECK to help find the root cause of the issue. BUG=359406 Committed: https://crrev.com/9c113aa9332c0d10720a8d6172391679704419e5 Cr-Commit-Position: refs/heads/master@{#363323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/metrics/field_trial_synchronizer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Alexei Svitkine (slow)
5 years ago (2015-12-04 20:58:38 UTC) #2
Nico
lgtm
5 years ago (2015-12-04 20:59:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503553003/1
5 years ago (2015-12-04 21:10:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-05 00:47:34 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-05 00:48:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c113aa9332c0d10720a8d6172391679704419e5
Cr-Commit-Position: refs/heads/master@{#363323}

Powered by Google App Engine
This is Rietveld 408576698