Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: chrome/browser/metrics/field_trial_synchronizer.cc

Issue 1503553003: Add another CHECK to diagnose Android crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/field_trial_synchronizer.cc
diff --git a/chrome/browser/metrics/field_trial_synchronizer.cc b/chrome/browser/metrics/field_trial_synchronizer.cc
index 9dab6c1f3bd88f7a4f3d0ba76fc51bb21f41b023..906f637efdbff26e8ffefe611e761402e3016ac9 100644
--- a/chrome/browser/metrics/field_trial_synchronizer.cc
+++ b/chrome/browser/metrics/field_trial_synchronizer.cc
@@ -51,7 +51,11 @@ void FieldTrialSynchronizer::NotifyAllRenderers(
void FieldTrialSynchronizer::OnFieldTrialGroupFinalized(
const std::string& field_trial_name,
const std::string& group_name) {
+ // TODO(asvitkine): Remove these CHECKs once http://crbug.com/359406 is fixed.
CHECK(!field_trial_name.empty() && !group_name.empty());
+ CHECK_EQ(group_name, base::FieldTrialList::FindFullName(field_trial_name))
+ << field_trial_name << ":" << group_name << "=>"
+ << base::FieldTrialList::FindFullName(field_trial_name);
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&FieldTrialSynchronizer::NotifyAllRenderers,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698