Check that shared memory GpuMemoryBuffer opening succeeds

Check that shared memory GpuMemoryBuffer opening succeeds

BUG=554541
Committed: https://crrev.com/1543aff69b5dc2aedb0b0d5a52875c7efaafd687
Cr-Commit-Position: refs/heads/master@{#364491}

[reveman, 2015-12-08 18:05:50]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2015-12-08 18:05:50]

https://codereview.chromium.org/1503393005/diff/1/content/common/gpu/client/g...
File content/common/gpu/client/gpu_memory_buffer_impl.cc (right):

https://codereview.chromium.org/1503393005/diff/1/content/common/gpu/client/g...
content/common/gpu/client/gpu_memory_buffer_impl.cc:51: CHECK(buffer);
How about changing the base::SharedMemory::IsHandleValid check in
GpuMemoryBufferImplSharedMemory::CreateFromHandle to a DCHECK and then we'll
fail in release builds properly with an OOM error when trying to map the buffer?
That would be consistent with how we handle this type of errors for shared
bitmaps and discardable memory.

[ccameron, 2015-12-08 21:06:00]

sg -- updated.

[reveman, 2015-12-08 22:13:24]

thanks lgtm

if this starts failing, feel free to create a bug and assign it to me

[ccameron, 2015-12-10 01:35:44]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2015-12-10 01:35:44]

Thanks -- adding avi@ as content/ OWNER (same deal as before).

[Avi (use Gerrit), 2015-12-10 15:26:33]

lgtm

[ccameron, 2015-12-10 18:58:48]

Thanks!

[ccameron, 2015-12-10 18:58:52]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2015-12-10 18:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503393005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503393005/20001

[commit-bot: I haz the power, 2015-12-10 21:57:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 21:58:25]

Description was changed from

==========
Check that shared memory GpuMemoryBuffer opening succeeds

BUG=554541
==========

to

==========
Check that shared memory GpuMemoryBuffer opening succeeds

BUG=554541

Committed: https://crrev.com/1543aff69b5dc2aedb0b0d5a52875c7efaafd687
Cr-Commit-Position: refs/heads/master@{#364491}
==========

[commit-bot: I haz the power, 2015-12-10 21:58:25]

Patchset 2 (id:??) landed as
https://crrev.com/1543aff69b5dc2aedb0b0d5a52875c7efaafd687
Cr-Commit-Position: refs/heads/master@{#364491}