Check that shared memory GpuMemoryBuffer opening succeeds

content/common/gpu/client/gpu_memory_buffer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "base/logging.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h"
 
 #if defined(OS_MACOSX)
@@ skipping 26 matching lines @@
 }
 
 // static
 scoped_ptr<GpuMemoryBufferImpl> GpuMemoryBufferImpl::CreateFromHandle(
     const gfx::GpuMemoryBufferHandle& handle,
     const gfx::Size& size,
     gfx::BufferFormat format,
     gfx::BufferUsage usage,
     const DestructionCallback& callback) {
   switch (handle.type) {
-    case gfx::SHARED_MEMORY_BUFFER:
-      return GpuMemoryBufferImplSharedMemory::CreateFromHandle(
-          handle, size, format, usage, callback);
+    case gfx::SHARED_MEMORY_BUFFER: {
+      scoped_ptr<GpuMemoryBufferImpl> buffer =
+          GpuMemoryBufferImplSharedMemory::CreateFromHandle(
+              handle, size, format, usage, callback);
+      CHECK(buffer);

[reveman, 2015/12/08 18:05:50]

How about changing the base::SharedMemory::IsHandleValid check in
GpuMemoryBufferImplSharedMemory::CreateFromHandle to a DCHECK and then we'll
fail in release builds properly with an OOM error when trying to map the buffer?
That would be consistent with how we handle this type of errors for shared
bitmaps and discardable memory.

+      return buffer.Pass();
+    }
 #if defined(OS_MACOSX)
     case gfx::IO_SURFACE_BUFFER:
       return GpuMemoryBufferImplIOSurface::CreateFromHandle(
           handle, size, format, usage, callback);
 #endif
 #if defined(OS_ANDROID)
     case gfx::SURFACE_TEXTURE_BUFFER:
       return GpuMemoryBufferImplSurfaceTexture::CreateFromHandle(
           handle, size, format, usage, callback);
 #endif
@@ skipping 24 matching lines @@
 
 gfx::GpuMemoryBufferId GpuMemoryBufferImpl::GetId() const {
   return id_;
 }
 
 ClientBuffer GpuMemoryBufferImpl::AsClientBuffer() {
   return reinterpret_cast<ClientBuffer>(this);
 }
 
 }  // namespace content