OFStream should have a virtual destructor.

OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=

Committed: https://crrev.com/42963f41bae84e2ac3a9a196e794e25e22dca4d1
Cr-Commit-Position: refs/heads/master@{#32688}

[Mircea Trofin, 2015-12-08 18:54:22]

Description was changed from

==========
OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=
==========

to

==========
OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=
==========

[Mircea Trofin, 2015-12-08 18:54:22]

mtrofin@chromium.org changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[Benedikt Meurer, 2015-12-09 04:03:35]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-12-09 04:07:28]

lgtm

[commit-bot: I haz the power, 2015-12-09 04:20:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1503383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1503383003/1

[commit-bot: I haz the power, 2015-12-09 04:34:09]

Description was changed from

==========
OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=
==========

to

==========
OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=
==========

[commit-bot: I haz the power, 2015-12-09 04:34:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-09 04:34:24]

Description was changed from

==========
OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=
==========

to

==========
OFStream should have a virtual destructor.

I noticed that using --print-opt-code was producing output unreliably.
Upon investigation, it turns out OFStream's destructor was not marked
virtual. Fixing this fixes the problem, as ostream flushes at destruction.

BUG=

Committed: https://crrev.com/42963f41bae84e2ac3a9a196e794e25e22dca4d1
Cr-Commit-Position: refs/heads/master@{#32688}
==========

[commit-bot: I haz the power, 2015-12-09 04:34:25]

Patchset 1 (id:??) landed as
https://crrev.com/42963f41bae84e2ac3a9a196e794e25e22dca4d1
Cr-Commit-Position: refs/heads/master@{#32688}