src/ostreams.h - Issue 1503383003: OFStream should have a virtual destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ostreams.h

Issue 1503383003: OFStream should have a virtual destructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ostreams.h

diff --git a/src/ostreams.h b/src/ostreams.h

index 6f8600e7b1c522b6d3aab16be4bc63e74fe42cb5..56f4aa7e45b766392699c6d36e49793071f0989d 100644

--- a/src/ostreams.h

+++ b/src/ostreams.h

@@ -36,7 +36,7 @@ class OFStreamBase : public std::streambuf {

class OFStream : public std::ostream {

public:

explicit OFStream(FILE* f);

- ~OFStream();

+ virtual ~OFStream();

private:

OFStreamBase buf_;

« no previous file with comments | « no previous file | no next file » | no next file with comments »