Add Sxtb instructions to ARM integrated assembler.

Add Sxtb/Sxth instructions to ARM integrated assembler.

Refactors code to take advantage of these instructions with
Uxtb/Uxth.

Note. These instructions are used by Subzero, but not Dart.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1e67f91a2075b46c7ba84ca48933399c249e4416

[Karl, 2015-12-07 21:25:49]

Description was changed from

==========
Add Sxtb/Sxth/Uxtb/Uxth instructions to ARM integrated assembler.

Note. These instructions are used by Subzero, but not Dart.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add Sxtb/Sxth instructions to ARM integrated assembler.

Refactors code to take advantage of these instructions with
Uxtb/Uxth.

Note. These instructions are used by Subzero, but not Dart.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-12-07 21:27:18]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-12-08 05:57:24]

lgtm

https://codereview.chromium.org/1503273002/diff/1/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1503273002/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:866: ": Type of Rm not understood");
Would be nice to have a "break;" here.

[Karl, 2015-12-08 19:17:26]

Description was changed from

==========
Add Sxtb/Sxth instructions to ARM integrated assembler.

Refactors code to take advantage of these instructions with
Uxtb/Uxth.

Note. These instructions are used by Subzero, but not Dart.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add Sxtb/Sxth instructions to ARM integrated assembler.

Refactors code to take advantage of these instructions with
Uxtb/Uxth.

Note. These instructions are used by Subzero, but not Dart.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2015-12-08 19:17:27]

Committed patchset #2 (id:20001) manually as
1e67f91a2075b46c7ba84ca48933399c249e4416 (presubmit successful).

[Karl, 2015-12-08 19:17:43]

https://codereview.chromium.org/1503273002/diff/1/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1503273002/diff/1/src/IceAssemblerARM32.cpp#n...
src/IceAssemblerARM32.cpp:866: ": Type of Rm not understood");
On 2015/12/08 05:57:24, stichnot wrote:
> Would be nice to have a "break;" here.

Done.