Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503193002: Start objectifying GrAtlasTextBlob (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start objectifying GrAtlasTextBlob BUG=skia: Committed: https://skia.googlesource.com/skia/+/3660d534516e4687546a43ac80d0ae40bc68dae7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -56 lines) Patch
M src/gpu/GrAtlasTextBlob.h View 6 chunks +49 lines, -14 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 12 chunks +23 lines, -25 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 8 chunks +16 lines, -15 lines 0 comments Download

Dependent Patchsets:

Issue 1502323002 Patch 1
Issue 1502323002 Patch 20001
Issue 1502323002 Patch 40001

Messages

Total messages: 7 (3 generated)
joshualitt
This makes the subrun an actual object.
5 years ago (2015-12-07 19:05:52 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-07 19:14:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503193002/1
5 years ago (2015-12-07 19:19:47 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-07 19:32:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3660d534516e4687546a43ac80d0ae40bc68dae7

Powered by Google App Engine
This is Rietveld 408576698