Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1502323002: A small cleanup of GrAtlasTextContext (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

A small cleanup of GrAtlasTextContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/18b072dbcb2df81945b87449b591c4b244e7fa37

Patch Set 1 #

Patch Set 2 : comment tweak #

Patch Set 3 : fix refcount issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -94 lines) Patch
M src/gpu/GrAtlasTextBlob.h View 1 2 4 chunks +25 lines, -13 lines 0 comments Download
M src/gpu/GrAtlasTextBlob.cpp View 1 1 chunk +63 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 5 chunks +4 lines, -77 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
joshualitt
This code moves the glyph appending routine to internal to textblob itself, and also removes ...
5 years ago (2015-12-07 19:42:56 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-07 19:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502323002/20001
5 years ago (2015-12-07 19:58:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502323002/40001
5 years ago (2015-12-07 20:12:05 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-07 20:26:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/18b072dbcb2df81945b87449b591c4b244e7fa37

Powered by Google App Engine
This is Rietveld 408576698