Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1502963004: Use content::NavigateIframeToURL in ProcessManagerBrowserTest (Closed)

Created:
5 years ago by robwu
Modified:
5 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, lfg, nasko, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use content::NavigateIframeToURL in ProcessManagerBrowserTest In 1413853005 I introduced NavigateIframeToURLAndWait in a test because the current content::NavigateIframeToURL implementation does not account for nested frames. https://codereview.chromium.org/1522443004/ fixes the issue, so let's use it. ChromeSitePerProcessTest.PluginWithRemoteTopFrame has been updated because I noticed that the flash object that was supposed to be loaded did not load because the file path was incorrect. Committed: https://crrev.com/57afbcaf67478de645c7e27040795f209057c244 Cr-Commit-Position: refs/heads/master@{#366416}

Patch Set 1 #

Patch Set 2 : Re-introduce wait-for-commit + fix PluginWithRemoteTopFrame test #

Patch Set 3 : Stick to onload/onerror events #

Patch Set 4 : Avoid 2 concurrent domAutomationController to pass ChromeSitePerProcessTest.PluginWithRemoteTopFrame #

Total comments: 2

Patch Set 5 : Rebase and use content::NavigateIframeToURL from https://codereview.chromium.org/1522443004/ #

Total comments: 5

Patch Set 6 : Remove paranoid onload check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -48 lines) Patch
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 2 3 4 5 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/process_manager_browsertest.cc View 1 2 3 4 10 chunks +14 lines, -33 lines 0 comments Download
M chrome/test/data/flash_object.html View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
robwu
5 years ago (2015-12-10 17:55:30 UTC) #4
ncarter (slow)
Charlie, can you review this?
5 years ago (2015-12-10 21:27:28 UTC) #6
Charlie Reis
[+nasko, lfg, site-isolation-reviews] https://codereview.chromium.org/1502963004/diff/100001/content/public/test/browser_test_utils.cc File content/public/test/browser_test_utils.cc (right): https://codereview.chromium.org/1502963004/diff/100001/content/public/test/browser_test_utils.cc#newcode316 content/public/test/browser_test_utils.cc:316: // something else. See https://crbug.com/436250. I've ...
5 years ago (2015-12-11 22:15:30 UTC) #7
robwu
https://codereview.chromium.org/1502963004/diff/100001/content/public/test/browser_test_utils.cc File content/public/test/browser_test_utils.cc (right): https://codereview.chromium.org/1502963004/diff/100001/content/public/test/browser_test_utils.cc#newcode316 content/public/test/browser_test_utils.cc:316: // something else. See https://crbug.com/436250. On 2015/12/11 22:15:29, Charlie ...
5 years ago (2015-12-16 09:28:34 UTC) #9
Charlie Reis
Adding Alex for the flash test changes, which I'm not sure I fully understand yet. ...
5 years ago (2015-12-16 18:44:58 UTC) #11
Charlie Reis
https://codereview.chromium.org/1502963004/diff/120001/chrome/browser/chrome_site_per_process_browsertest.cc File chrome/browser/chrome_site_per_process_browsertest.cc (right): https://codereview.chromium.org/1502963004/diff/120001/chrome/browser/chrome_site_per_process_browsertest.cc#newcode107 chrome/browser/chrome_site_per_process_browsertest.cc:107: // Serve from the root so that flash_object.html can ...
5 years ago (2015-12-16 20:41:37 UTC) #12
alexmos
https://codereview.chromium.org/1502963004/diff/120001/chrome/browser/chrome_site_per_process_browsertest.cc File chrome/browser/chrome_site_per_process_browsertest.cc (right): https://codereview.chromium.org/1502963004/diff/120001/chrome/browser/chrome_site_per_process_browsertest.cc#newcode107 chrome/browser/chrome_site_per_process_browsertest.cc:107: // Serve from the root so that flash_object.html can ...
5 years ago (2015-12-17 02:04:30 UTC) #13
robwu
https://codereview.chromium.org/1502963004/diff/120001/chrome/browser/chrome_site_per_process_browsertest.cc File chrome/browser/chrome_site_per_process_browsertest.cc (right): https://codereview.chromium.org/1502963004/diff/120001/chrome/browser/chrome_site_per_process_browsertest.cc#newcode137 chrome/browser/chrome_site_per_process_browsertest.cc:137: "}"); On 2015/12/16 18:44:58, Charlie Reis (OOO till Jan ...
5 years ago (2015-12-18 09:18:01 UTC) #15
Charlie Reis
Thanks! LGTM.
5 years ago (2015-12-18 15:52:40 UTC) #16
robwu
+jochen for rubberstamping chrome/.
5 years ago (2015-12-18 15:59:16 UTC) #18
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-21 12:38:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502963004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502963004/140001
5 years ago (2015-12-21 16:29:47 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:140001)
5 years ago (2015-12-21 17:52:18 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-21 17:53:09 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/57afbcaf67478de645c7e27040795f209057c244
Cr-Commit-Position: refs/heads/master@{#366416}

Powered by Google App Engine
This is Rietveld 408576698