Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 150273003: Don't allow style sharing between top layer and non-top layer elements (Closed)

Created:
6 years, 10 months ago by falken
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, ed+blinkwatch_opera.com, darktears
Visibility:
Public.

Description

Don't allow style sharing between top layer and non-top layer elements Normally, top layer elements are ensured a layer in adjustRenderStyle. However, if style sharing occurs, the top layer element can receive a style that causes it to not have a layer, which will break top layer rendering. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A LayoutTests/fast/dom/HTMLDialogElement/dont-share-style-to-top-layer.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLDialogElement/dont-share-style-to-top-layer-expected.html View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
falken
morrita@: r?
6 years, 10 months ago (2014-01-31 07:26:30 UTC) #1
hayato
LGTM.
6 years, 10 months ago (2014-01-31 08:13:35 UTC) #2
Hajime Morrita
lgtm. @ojan an @esprehn may have some opinion in this area.
6 years, 10 months ago (2014-01-31 08:14:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/150273003/1
6 years, 10 months ago (2014-01-31 08:14:10 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10231
6 years, 10 months ago (2014-01-31 10:59:53 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 10:59:55 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 10:59:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/150273003/1
6 years, 10 months ago (2014-01-31 11:04:21 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 14:23:14 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 14:23:14 UTC) #10
commit-bot: I haz the power
Change committed as 166215
6 years, 10 months ago (2014-01-31 14:23:14 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 14:23:17 UTC) #12
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698