Source/core/css/resolver/SharedStyleFinder.cpp - Issue 150273003: Don't allow style sharing between top layer and non-top layer elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 150273003: Don't allow style sharing between top layer and non-top layer elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/SharedStyleFinder.cpp

diff --git a/Source/core/css/resolver/SharedStyleFinder.cpp b/Source/core/css/resolver/SharedStyleFinder.cpp

index a82521d270e3f05fa027289ca10e4e4480cb92df..9ee0d9b1e070fe09dd19049b1603c41a9797d5bb 100644

--- a/Source/core/css/resolver/SharedStyleFinder.cpp

+++ b/Source/core/css/resolver/SharedStyleFinder.cpp

@@ -209,6 +209,8 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const

return false;

if (candidate.shadow() && candidate.shadow()->containsActiveStyles() && !sharingCandidateShadowHasSharedStyleSheetContents(candidate))

return false;

+ if (candidate.isInTopLayer() != element().isInTopLayer())

+ return false;

bool isControl = candidate.isFormControlElement();

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/dont-share-style-to-top-layer-expected.html ('k') | no next file » | no next file with comments »