Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1502703002: [Contextual Search] Remove layers when no longer needed. (Closed)

Created:
5 years ago by pedro (no code reviews)
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Remove layers when no longer needed. Now that there can be multiple Overlays Panels being used, a few bugs are happening due to the Panel's cc::Layer not being properly removed. This CL fixes the problem by removing the layer when a OverlayPanel shows up when another one is being displayed. Also, this CL removed the OverlayPanel layer from the StaticLayout whenever that layout gets hidden (see dettachViews method). BUG=539847 Review URL: https://codereview.chromium.org/1489213002 Cr-Commit-Position: refs/heads/master@{#363092} (cherry picked from commit a53e46eff945b879f6e72108073d3d70d47d6b0e) Committed: https://chromium.googlesource.com/chromium/src/+/a9c0375ea30b080e06f8d5f646e8b31e43c42608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/static_tab_scene_layer.cc View 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pedro (no code reviews)
5 years ago (2015-12-04 23:08:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9c0375ea30b080e06f8d5f646e8b31e43c42608 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698