DescriptionRevert 198871 "Speed improvements to SubstringSetMatcher"
Win debug trybots fire assertions on SubstringSetMatcherTest.TestMatcher and WebRequestRulesRegistryTest.GetMatchesCheckFulfilled
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\algorithm(3657) : Assertion failed: invalid operator<
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(78) : Assertion failed: string iterator not dereferencable
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(79) : Assertion failed: "Standard C++ Libraries Out of Range" && 0
> Speed improvements to SubstringSetMatcher
>
> This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/.
> Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly.
>
> Original description:
>
> The main one is coputing the Aho-Corasick tree size in advance.
>
> Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.
>
> This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.
>
> BUG=236368
> TBR=battre
>
> Review URL: https://codereview.chromium.org/15059003
TBR=battre@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198874
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|