Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 15027007: Revert 198871 "Speed improvements to SubstringSetMatcher" (Closed)

Created:
7 years, 7 months ago by vabr (Chromium)
Modified:
7 years, 7 months ago
Reviewers:
battre
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198871 "Speed improvements to SubstringSetMatcher" Win debug trybots fire assertions on SubstringSetMatcherTest.TestMatcher and WebRequestRulesRegistryTest.GetMatchesCheckFulfilled c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\algorithm(3657) : Assertion failed: invalid operator< c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(78) : Assertion failed: string iterator not dereferencable c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(79) : Assertion failed: "Standard C++ Libraries Out of Range" && 0 > Speed improvements to SubstringSetMatcher > > This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/. > Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly. > > Original description: > > The main one is coputing the Aho-Corasick tree size in advance. > > Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations. > > This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%. > > BUG=236368 > TBR=battre > > Review URL: https://codereview.chromium.org/15059003 TBR=battre@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -123 lines) Patch
M trunk/src/extensions/common/matcher/substring_set_matcher.h View 4 chunks +11 lines, -15 lines 0 comments Download
M trunk/src/extensions/common/matcher/substring_set_matcher.cc View 9 chunks +44 lines, -108 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vabr (Chromium)
7 years, 7 months ago (2013-05-08 11:51:05 UTC) #1
vabr (Chromium)
7 years, 7 months ago (2013-05-08 11:51:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r198874.

Powered by Google App Engine
This is Rietveld 408576698