Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 15059003: Speed improvements to SubstringSetMatcher (Closed)

Created:
7 years, 7 months ago by vabr (Chromium)
Modified:
7 years, 7 months ago
Reviewers:
battre
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Speed improvements to SubstringSetMatcher This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/. Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly. Original description: The main one is coputing the Aho-Corasick tree size in advance. Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations. This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%. BUG=236368 TBR=battre Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198871

Patch Set 1 #

Patch Set 2 : Moving the kNoSuchEdge definition to a cc file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -55 lines) Patch
M extensions/common/matcher/substring_set_matcher.h View 1 4 chunks +15 lines, -11 lines 0 comments Download
M extensions/common/matcher/substring_set_matcher.cc View 1 9 chunks +108 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vabr (Chromium)
Hi Dominic, I'm going to TBR you on this, as it is a trivial change ...
7 years, 7 months ago (2013-05-08 09:32:14 UTC) #1
vabr (Chromium)
7 years, 7 months ago (2013-05-08 10:06:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r198871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698