Source/core/rendering/RenderNamedFlowThread.cpp - Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderNamedFlowThread.cpp

Issue 15027005: [CSS Regions] Elements in a region should be assignable to a named flow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Integrates all feedback. One of the tests causes an ASSERT in ContentShell because of Region Ranges. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/NodeRenderingContext.cpp ('K') | « Source/core/rendering/FlowThreadController.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderNamedFlowThread.cpp

diff --git a/Source/core/rendering/RenderNamedFlowThread.cpp b/Source/core/rendering/RenderNamedFlowThread.cpp

index f83f46c78a403812d6227a5676ff8ffd2cbd0b6e..a25a37399e008424d89d66b6c875e2b14f508cd9 100644

--- a/Source/core/rendering/RenderNamedFlowThread.cpp

+++ b/Source/core/rendering/RenderNamedFlowThread.cpp

@@ -413,6 +413,8 @@ bool RenderNamedFlowThread::isChildAllowed(RenderObject* child, RenderStyle* sty

ASSERT(child->node()->isElementNode());

RenderObject* parentRenderer = NodeRenderingContext(child->node()).parentRenderer();

+ if (!parentRenderer)

+ return true;

return parentRenderer->isChildAllowed(child, style);

}