Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 15027002: Fix the remaining heap-buffer-overflow (read) error in arcfour.c. (Closed)

Created:
7 years, 7 months ago by wtc
Modified:
7 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the remaining heap-buffer-overflow (read) error in arcfour.c. R=rsleevi@chromium.org BUG=174140 TEST=none

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M nss/lib/freebl/arcfour.c View 6 chunks +10 lines, -10 lines 5 comments Download

Messages

Total messages: 6 (0 generated)
wtc
rsleevi: I'm sorry to inflict the pain of reviewing arcfour.c on you again. My previous ...
7 years, 7 months ago (2013-05-07 18:00:49 UTC) #1
Ryan Sleevi
Thank you for your helpful comments. I worked through the algorithm by hand for different ...
7 years, 7 months ago (2013-05-07 19:56:08 UTC) #2
wtc
On 2013/05/07 19:56:08, Ryan Sleevi wrote: > To confirm, the issue was a heap-buffer-overflow in ...
7 years, 7 months ago (2013-05-07 21:22:32 UTC) #3
Ryan Sleevi
On 2013/05/07 21:22:32, wtc wrote: > On 2013/05/07 19:56:08, Ryan Sleevi wrote: > > To ...
7 years, 7 months ago (2013-05-07 21:27:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/15027002/1
7 years, 7 months ago (2013-05-07 21:35:15 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 21:35:22 UTC) #6
Message was sent while issue was closed.
Change committed as 198802

Powered by Google App Engine
This is Rietveld 408576698