chrome/test/data/save_page/frames-runtime-changes.htm - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/save_page/frames-runtime-changes.htm

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Addressed feedback from Randy (and apparently accidentally rebased as well...). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/save_item.h » ('j') | content/renderer/dom_serializer_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/save_page/frames-runtime-changes.htm

diff --git a/chrome/test/data/save_page/frames-runtime-changes.htm b/chrome/test/data/save_page/frames-runtime-changes.htm

index 897f15aca5879f3c90cef8e0d2356fde75389bb9..78caad37aa09dd5808f6c639bc335c3b7bc76c26 100644

--- a/chrome/test/data/save_page/frames-runtime-changes.htm

+++ b/chrome/test/data/save_page/frames-runtime-changes.htm

@@ -8,7 +8,7 @@ function addNewMarker(elementId, marker) {

}

function onLoad() {

- if (location.href.indexOf("do_runtime_changes") == (-1))

+ if (location.href.indexOf("do_runtime_changes=1") == (-1))

return

addNewMarker("subframe1", "21595339-61fc-4854-b6df-0668328ea263")

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/save_item.h » ('j') | content/renderer/dom_serializer_browsertest.cc » ('J')