chrome/test/data/save_page/frames-runtime-changes.htm - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/save_page/frames-runtime-changes.htm

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Addressed feedback from Randy (and apparently accidentally rebased as well...). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script type="text/javascript">	4 <script type="text/javascript">

5 function addNewMarker(elementId, marker) {	5 function addNewMarker(elementId, marker) {

6 f = document.getElementById(elementId)	6 f = document.getElementById(elementId)

7 f.contentDocument.body.innerHTML = elementId + ": " + marker	7 f.contentDocument.body.innerHTML = elementId + ": " + marker

8 }	8 }

9	9

10 function onLoad() {	10 function onLoad() {

11 if (location.href.indexOf("do_runtime_changes") == (-1))	11 if (location.href.indexOf("do_runtime_changes=1") == (-1))

12 return	12 return

13	13

14 addNewMarker("subframe1", "21595339-61fc-4854-b6df-0668328ea263")	14 addNewMarker("subframe1", "21595339-61fc-4854-b6df-0668328ea263")

15 addNewMarker("subframe2", "adf55719-15e7-45be-9eda-d12fe782a1bd")	15 addNewMarker("subframe2", "adf55719-15e7-45be-9eda-d12fe782a1bd")

16 addNewMarker("subframe3", "50e294bf-3a5b-499d-8772-651ead26952f")	16 addNewMarker("subframe3", "50e294bf-3a5b-499d-8772-651ead26952f")

17 addNewMarker("subframe4", "e0ea9289-7467-4d32-ba5c-c604e8d84cb7")	17 addNewMarker("subframe4", "e0ea9289-7467-4d32-ba5c-c604e8d84cb7")

18 }	18 }

19 </script>	19 </script>

20 </head>	20 </head>

21 <body onload="onLoad()">	21 <body onload="onLoad()">

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 srcdoc4: c60fa69e-20a8-4cb0-ad9d-122355fe2522	65 srcdoc4: c60fa69e-20a8-4cb0-ad9d-122355fe2522

66 <br>	66 <br>

67 <br>	67 <br>

68 </body>	68 </body>

69 </html>"></iframe>	69 </html>"></iframe>

70 <br>	70 <br>

71 <br>	71 <br>

72	72

73 </body>	73 </body>

74 </html>	74 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/save_item.h » ('j') | content/renderer/dom_serializer_browsertest.cc » ('J')