Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1706)

Unified Diff: dart/tests/html/track_element_constructor_test.dart

Issue 15024008: Avoid syntax errors on oddly named fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/html/track_element_constructor_test.dart
diff --git a/dart/tests/html/track_element_constructor_test.dart b/dart/tests/html/track_element_constructor_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..6081e8a09109cdad9e2fd493a4389bab4f868f66
--- /dev/null
+++ b/dart/tests/html/track_element_constructor_test.dart
@@ -0,0 +1,23 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// A regression test for dart2js generating illegal JavaScript code
+// dynamically in non-csp mode. The name of the field "defaultValue"
+// in JavaScript is "default". This meant that dart2js would create a
+// constructor function that looked like this:
+//
+// function TrackElement(default) { this.default = default; }
+
+import 'dart:html';
+
+void main() {
+ document.body.append(new TrackElement()..defaultValue = true);
+ if (!document.query('track').defaultValue) {
+ throw 'Expected default value to be true';
sra1 2013/05/16 00:09:31 All the other tests under tests/html use the unit
ahe 2013/05/16 12:41:56 I've added a test to dart2js_native that is much m
+ }
+ document.query('track').defaultValue = false;
+ if (document.query('track').defaultValue) {
+ throw 'Expected default value to be false';
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698