Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11616)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 15024008: Avoid syntax errors on oddly named fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 37be935d403a9aff6d503c8ced25b6b4056aee8f..700d687f0d9f70fc13767dc2298cc1a197e8d07e 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -313,9 +313,10 @@ class CodeEmitterTask extends CompilerTask {
js.if_('i != 0', js('str += ", "')),
js('var field = fields[i]'),
+ js('var parameter = "parameter" + i'),
sra1 2013/05/16 00:09:31 This would give more readable code when you single
ahe 2013/05/16 12:41:56 Great idea. Done.
js('field = generateAccessor(field, prototype)'),
- js('str += field'),
- js('body += ("this." + field + " = " + field + ";\\n")')
+ js('str += parameter'),
+ js('body += ("this." + field + " = " + parameter + ";\\n")')
]),
js('str += (") {" + body + "}\\nreturn " + cls)'),

Powered by Google App Engine
This is Rietveld 408576698