Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 150223002: Add 'static type error' tags to multitests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rename 'static type error' to 'checked mode compile-time error'. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index a2056ab725b80ca527d41305868226ea2a199c36..689751f1c206cef731a1047311ffea843a6d2cb8 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -81,15 +81,18 @@ List<String> _buildFailureOutput(TestCase test,
output.add('Actual: ${test.result}');
if (!test.lastCommandOutput.hasTimedOut && test.info != null) {
if (test.commandOutputs.length != test.commands.length
- && !test.info.hasCompileError) {
+ && !test.expectCompileError) {
output.add('Unexpected compile-time error.');
} else {
- if (test.info.hasCompileError) {
+ if (test.expectCompileError) {
output.add('Compile-time error expected.');
}
if (test.info.hasRuntimeError) {
output.add('Runtime error expected.');
}
+ if (test.configuration['checked'] && test.info.isNegativeIfChecked) {
+ output.add('Dynamic type error expected.');
+ }
}
}
for (var i = 0; i < test.commands.length; i++) {
« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698